JoeBot/HOA_Financial_Platform
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Fix dashboard KPIs: resolve nested aggregate and missing column errors

Browse Source 
- Wrap account interest query in subquery to avoid SUM(SUM(...)) nesting
- Replace nonexistent interest_earned column with current_value - principal

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
olsch01
2026-02-27 09:11:37 -05:00
parent 0e82e238c1
commit d1c40c633f
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
backend/src/modules/reports/reports.service.ts
View File

@@ -508,26 +508,26 @@ export class ReportsService {
// Monthly interest estimate from accounts + investments with rates // Monthly interest estimate from accounts + investments with rates
const acctInterest = await this.tenant.query(` const acctInterest = await this.tenant.query(`
SELECT COALESCE(SUM( SELECT COALESCE(SUM(sub.monthly_interest), 0) as total FROM (
(COALESCE(SUM(jel.debit), 0) - COALESCE(SUM(jel.credit), 0)) * (a.interest_rate / 100) / 12 SELECT (COALESCE(SUM(jel.debit), 0) - COALESCE(SUM(jel.credit), 0)) * (a.interest_rate / 100) / 12 as monthly_interest
), 0) as total
FROM accounts a FROM accounts a
LEFT JOIN journal_entry_lines jel ON jel.account_id = a.id LEFT JOIN journal_entry_lines jel ON jel.account_id = a.id
LEFT JOIN journal_entries je ON je.id = jel.journal_entry_id AND je.is_posted = true AND je.is_void = false LEFT JOIN journal_entries je ON je.id = jel.journal_entry_id AND je.is_posted = true AND je.is_void = false
WHERE a.account_type = 'asset' AND a.is_active = true AND a.interest_rate > 0 WHERE a.account_type = 'asset' AND a.is_active = true AND a.interest_rate > 0
GROUP BY a.id GROUP BY a.id, a.interest_rate
) sub
`); `);
const acctInterestTotal = (acctInterest || []).reduce((s: number, r: any) => s + parseFloat(r.total || '0'), 0); const acctInterestTotal = parseFloat(acctInterest[0]?.total || '0');
const invInterest = await this.tenant.query(` const invInterest = await this.tenant.query(`
SELECT COALESCE(SUM(current_value * interest_rate / 100 / 12), 0) as total SELECT COALESCE(SUM(current_value * interest_rate / 100 / 12), 0) as total
FROM investment_accounts WHERE is_active = true AND interest_rate > 0 FROM investment_accounts WHERE is_active = true AND interest_rate > 0
`); `);
const estMonthlyInterest = acctInterestTotal + parseFloat(invInterest[0]?.total || '0'); const estMonthlyInterest = acctInterestTotal + parseFloat(invInterest[0]?.total || '0');
// Interest earned YTD from investment accounts // Interest earned YTD: approximate from current_value - principal (unrealized gains)
const interestEarned = await this.tenant.query(` const interestEarned = await this.tenant.query(`
SELECT COALESCE(SUM(interest_earned), 0) as total SELECT COALESCE(SUM(current_value - principal), 0) as total
FROM investment_accounts WHERE is_active = true FROM investment_accounts WHERE is_active = true AND current_value > principal
`); `);
// Planned capital spend for current year // Planned capital spend for current year